Skip to content

JIT: Delete unused functions - #131124

Merged
EgorBo merged 2 commits into
dotnet:mainfrom
EgorBo:delete-unused-jit-functions
Jul 24, 2026
Merged

JIT: Delete unused functions#131124
EgorBo merged 2 commits into
dotnet:mainfrom
EgorBo:delete-unused-jit-functions

Conversation

@EgorBo

@EgorBo EgorBo commented Jul 21, 2026

Copy link
Copy Markdown
Member

Delete unused functions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d4822663-897d-47d5-8d36-6128ffa76703
Copilot AI review requested due to automatic review settings July 21, 2026 01:21
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 21, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 6 pipeline(s).
10 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a set of unused helper functions (and associated declarations / dead debug code) from CoreCLR JIT sources to reduce maintenance surface and keep headers/implementation lean.

Changes:

  • Removed an unused debug-only heap verifier from PriorityQueue and the leftover commented assertions.
  • Removed unused LSRA helpers (range-check helpers, traversal-order stubs, reg-mask helpers, and an interval reg check).
  • Removed multiple unused Compiler helpers (debug dump utilities, early-prop/assertion helpers, loop-hoist per-method printing, node test-data transfer, and old standalone-JIT stubs), plus an unused RISC-V emitter helper and some lowering helpers.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/coreclr/jit/priorityqueue.h Removes unused debug-only heap verification code and dead commented assertions.
src/coreclr/jit/lsra.h Deletes unused LSRA helper methods and retail-build traversal-order stubs.
src/coreclr/jit/lower.h Removes unused lowering helper wrappers for common addressing patterns.
src/coreclr/jit/emitriscv64.cpp Removes an unused sign-extend helper template.
src/coreclr/jit/compiler.h Removes declarations for multiple unused Compiler helpers across debug/flowgraph/opt/test infra.
src/coreclr/jit/compiler.cpp Removes the corresponding unused Compiler method definitions and legacy standalone-JIT stubs.

Copilot AI review requested due to automatic review settings July 21, 2026 20:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

@EgorBo

EgorBo commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

PTAL @dotnet/jit-contrib just a simple cleanup

@EgorBo
EgorBo merged commit b8625e8 into dotnet:main Jul 24, 2026
141 checks passed
@EgorBo
EgorBo deleted the delete-unused-jit-functions branch July 24, 2026 02:19
hez2010 pushed a commit to hez2010/runtime that referenced this pull request Jul 26, 2026
Delete unused functions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d4822663-897d-47d5-8d36-6128ffa76703
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-rc1 milestone Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants